Conversation
|
Deploy preview for helix-react ready! Built with commit 7cab575 |
100stacks
requested changes
Oct 21, 2020
|
|
||
| return ( | ||
| <div> | ||
| <> |
Member
There was a problem hiding this comment.
Is this different from https://github.com/HelixDesignSystem/helix-react/pull/116/files#r508772386?
Contributor
Author
There was a problem hiding this comment.
Yep they are different, tooltips do not seem to suffer from the same issues as Alerts. The other difference is this is a storybook story and not a wrapper. Issue seems to popup when the wrappers top level HTML node gets unexpectedly removed by helix.
Member
There was a problem hiding this comment.
Ok thanks for the explanation here also. 🙂
100stacks
approved these changes
Oct 21, 2020
|
|
||
| return ( | ||
| <div> | ||
| <> |
Member
There was a problem hiding this comment.
Ok thanks for the explanation here also. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add event listeners to tool tips