feat(text): added invalid option to Text and TextArea wrappers#125
Merged
100stacks merged 2 commits intoHelixDesignSystem:masterfrom Jan 18, 2021
Merged
feat(text): added invalid option to Text and TextArea wrappers#125100stacks merged 2 commits intoHelixDesignSystem:masterfrom
100stacks merged 2 commits intoHelixDesignSystem:masterfrom
Conversation
abrande
commented
Jan 12, 2021
abrande
commented
- Added additional invalid and label options in storybook
|
✔️ Deploy preview for helix-react ready! 🔨 Explore the source changes: 64f7f1c 🔍 Inspect the deploy logs: https://app.netlify.com/sites/helix-react/deploys/6005c1df8884dd00072c7506 😎 Browse the preview: https://deploy-preview-125--helix-react.netlify.app |
nicko-winner
approved these changes
Jan 12, 2021
| {...(label && { label })} | ||
| {...(disabled && { disabled })} | ||
| {...(required && { required })} | ||
| {...(invalid && { invalid })} |
Contributor
There was a problem hiding this comment.
There are a few component examples in this file, it might be good to update them all with an invalid state since they all support disabled, required, etc.
100stacks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.