feat: migrate Helix-React to HelixUI v2.0 specs#127
Merged
Conversation
…ing existing one. - Can be helpful for folks using redux-form wrappers on their inputs. - Set medium size by default to prevent 'undefined' class name fro showing up in markup.
|
Deploy preview for helix-react ready! Built with commit e142102 |
abrande
approved these changes
Jan 26, 2021
100stacks
requested changes
Jan 28, 2021
abrande
approved these changes
Jan 29, 2021
100stacks
approved these changes
Feb 1, 2021
Member
100stacks
left a comment
100stacks
left a comment
There was a problem hiding this comment.
Great work, Nicko!!! 👏🎉
Dev LGTM
src/Toast/index.js
Outdated
| const hxRef = useEventListener({ onDismiss, onSubmit }, ref); | ||
| return ( | ||
| <div> | ||
| {/* Wrapping element needed: Otherwise when alert removes itself from DOM on close, it will cause error */} |
Member
There was a problem hiding this comment.
Suggested change
| {/* Wrapping element needed: Otherwise when alert removes itself from DOM on close, it will cause error */} | |
| {/* Wrapping element needed: Otherwise when Toast removes itself from DOM on close, it will cause error */} |
src/Tooltip/stories.js
Outdated
| let position = select('positions', POSITIONS, 'top-left'); | ||
| let content = text('content', 'I am a tool tip'); | ||
|
|
||
| const myRef = React.useRef(); |
Member
There was a problem hiding this comment.
Suggested change
| const myRef = React.useRef(); |
src/Tooltip/stories.js
Outdated
| onOpen={callback(action('onOpen'))} | ||
| onClose={callback(action('onClose'))} | ||
| onReposition={callback(action('onReposition'))} | ||
| ref={myRef} |
100stacks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.