Upgrade to Helix v0.19, React 16, and Storybook#77
Merged
Conversation
100stacks
requested changes
Mar 20, 2020
Member
100stacks
left a comment
100stacks
left a comment
There was a problem hiding this comment.
Any thoughts about updating all the dependencies?
|
Deploy preview for helix-react processing. Building with commit c98edb5 https://app.netlify.com/sites/helix-react/deploys/5e77dc764fee5df20a560e90 |
|
Deploy preview for helix-react ready! Built with commit a479c7d |
- Most of the storybook setOptions have been deprecated, decided to remove them in favor of new defaults storybook 5. (Name and URL are now set as part of the theme) - webpack.config.js no longer works in new version of storybook. Opting for defaults instead.
nicko-winner
changed the title
nicko-winner
changed the title
100stacks
requested changes
Mar 24, 2020
Member
100stacks
left a comment
100stacks
left a comment
There was a problem hiding this comment.
Looks awesome @nicko-winner...thanks for updating all of the dependencies!
Just one small change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Helix to v0.19, React 16, and Storybook 5
Storybook 3 (Before):
Storybook 5 (After):
todo: