Conversation
|
Deploy preview for helix-react ready! Built with commit fd7b466 |
src/Select/stories.js
Outdated
| <Demo required /> | ||
| ); | ||
| }) | ||
| .add('Optional', () => { |
There was a problem hiding this comment.
Other components use knobs for configuration. One of the advantages is they allow for multiple kinds of configuration at the same time such as "required, and disabled"
There was a problem hiding this comment.
my "required, disabled" example might not have been the best demonstration of the point I was trying to make. But the knobs do offer a consistent approach to manipulating the components and can be themed.
There was a problem hiding this comment.
At the heart of this comment is just a desire to have an approach that's consistent for changing component state across the project. If we use use knobs, great! if we controls inside the canvas like the tool tip story, I can get behind that too. Just looking for a consistent approach, we can apply so all stories work in a similar way. What are your thoughts? If there are no strong opinions yet, we can deal with it latter when there is more of a knowing about which approaches seem to work better, might just mean a little more rework if we wait too long.
There was a problem hiding this comment.
@HelixDesignSystem/helix-react-core, I agree it's better to go with @nicko-winner's recommendation to have a consistent approach:
At the heart of this comment is just a desire to have an approach that's consistent for changing component state across the project. If we use use knobs, great! if we controls inside the canvas like the tool tip story, I can get behind that too. Just looking for a consistent approach, we can apply so all stories work in a similar way. What are your thoughts? If there are no strong opinions yet, we can deal with it latter when there is more of a knowing about which approaches seem to work better, might just mean a little more rework if we wait too long.
I defer to you all for the LOE between using knobs vs another approach, though it does seem like knobs provide (implementation) consistency and flexibility.
100stacks
left a comment
100stacks
left a comment
There was a problem hiding this comment.
@HelixDesignSystem/helix-react-core great work and discussions guys...we're making progress! 💯
src/Select/stories.js
Outdated
| <Demo required /> | ||
| ); | ||
| }) | ||
| .add('Optional', () => { |
There was a problem hiding this comment.
@HelixDesignSystem/helix-react-core, I agree it's better to go with @nicko-winner's recommendation to have a consistent approach:
At the heart of this comment is just a desire to have an approach that's consistent for changing component state across the project. If we use use knobs, great! if we controls inside the canvas like the tool tip story, I can get behind that too. Just looking for a consistent approach, we can apply so all stories work in a similar way. What are your thoughts? If there are no strong opinions yet, we can deal with it latter when there is more of a knowing about which approaches seem to work better, might just mean a little more rework if we wait too long.
I defer to you all for the LOE between using knobs vs another approach, though it does seem like knobs provide (implementation) consistency and flexibility.
Prettier
I created a When you run Every time you do Our teams moves this into the webpack bundle pipeline so it becomes automatic but I'm deferring that here. If you add a prettier plugin to your code editor, that will also format against our prettier settings. I'm open to suggestions! |
|
@nicko-winner @100stacks this is ready for re-review |
nicko-winner
left a comment
nicko-winner
left a comment
There was a problem hiding this comment.
LGTM, but just noticed tooltip is missing some of the attributes / events. Can handle in a followup PR or address now.
|
|
||
| const Tooltip = ({ children, id, position }) => { | ||
| return ( | ||
| <hx-tooltip for={id} position={position}> |
There was a problem hiding this comment.
Can we add the events and attributes listed on this page: https://helixdesignsystem.github.io/helix-ui/elements/hx-tooltip/ ?
3 participants
Tooltip
Select
✅ Required and Optional variants