Conversation
|
Deploy preview for helix-react ready! Built with commit 83a356f |
nicko-winner
left a comment
nicko-winner
left a comment
There was a problem hiding this comment.
Great jobs with the docs! added a few suggestions
Co-authored-by: Nicko Winner-Arroyo <35456401+nicko-winner@users.noreply.github.com>
Co-authored-by: Nicko Winner-Arroyo <35456401+nicko-winner@users.noreply.github.com>
|
@nicko-winner feedback addressed, ready for a re-review |
README.md
Outdated
| For questions related to using the library, please visit a support community | ||
| instead of filing an issue on GitHub. | ||
|
|
||
| [Slack](https://join.slack.com/share/zt-edajgkat-LG_5SXYoCeIzknrQPVWaTA) |
There was a problem hiding this comment.
is there a policy around making a publicly accessible channel? or only rackers can access this channel?
There was a problem hiding this comment.
You bring up a good point about a publicly accessible channel.
External contributors will have to submit an issue. We can make an announcement internally on Slack when we're ready to go live.
100stacks
left a comment
100stacks
left a comment
There was a problem hiding this comment.
Looks great...just a few small changes.
README.md
Outdated
| ```bash | ||
| npm start | ||
| ``` | ||
| The script should automatically open Storybook in your browser, but you can always navigate to http:http://localhost:6006/?path=/story |
There was a problem hiding this comment.
Please remove the extra http:.
Also put the link in backticks, so that it's not a live link.
http://localhost:6006/?path=/story
README.md
Outdated
| For questions related to using the library, please visit a support community | ||
| instead of filing an issue on GitHub. | ||
|
|
||
| [Slack](https://join.slack.com/share/zt-edajgkat-LG_5SXYoCeIzknrQPVWaTA) |
There was a problem hiding this comment.
You bring up a good point about a publicly accessible channel.
External contributors will have to submit an issue. We can make an announcement internally on Slack when we're ready to go live.
README.md
Outdated
| <table> | ||
| <tr> | ||
| <td align="center"><a href="https://github.com/michaelmang"><img src="https://avatars0.githubusercontent.com/u/10120600?s=400&u=7a37b1eba79b6ee2c7753a457b8a33998595fe20&v=4" width="100px;" alt=""/><br /><sub><b>James Thompson</b></sub></a><br /><a href="https://github.com/HelixDesignSystem/helix-react/commits?author=100Stacks" title="Commits">💻</a></td> | ||
| <td align="center"><a href="https://github.com/michaelmang"><img src="https://avatars0.githubusercontent.com/u/35456401?s=400&v=4" width="100px;" alt=""/><br /><sub><b>Nicko Winner-Arroyo</b></sub></a><br /><a href="https://github.com/HelixDesignSystem/helix-react/commits?author=nicko-winner" title="Commits">💻</a></td> |
There was a problem hiding this comment.
Please update the link:
<a href="https://github.com/nicko-winner">
README.md
Outdated
|
|
||
| <table> | ||
| <tr> | ||
| <td align="center"><a href="https://github.com/michaelmang"><img src="https://avatars0.githubusercontent.com/u/10120600?s=400&u=7a37b1eba79b6ee2c7753a457b8a33998595fe20&v=4" width="100px;" alt=""/><br /><sub><b>James Thompson</b></sub></a><br /><a href="https://github.com/HelixDesignSystem/helix-react/commits?author=100Stacks" title="Commits">💻</a></td> |
There was a problem hiding this comment.
Please update the link:
<a href="https://github.com/100stacks">
README.md
Outdated
|  | ||
|
|
||
| These components are just the "building blocks" of other Helix patterns listed in | ||
| the [Helix design documentation](http://helix.rax.io/status.html). |
There was a problem hiding this comment.
That list is a little dated. Let's not link to it please.
|
@100stacks this is ready for re-review |
3 participants
Adds some basic documentation for the package.
When we open up outside contribution, we can update the readme accordingly.