Merged
Conversation
added 3 commits
May 15, 2020 16:02
|
Deploy preview for helix-react ready! Built with commit 0e06577 |
Contributor
Author
|
@nicko-winner ready for re-review |
100stacks
requested changes
May 16, 2020
| open={wcBool(open)} | ||
| {...rest} | ||
| > | ||
| <hx-modal class={classNames(className, SIZES[size])} ref={hxRef} open={wcBool(open)} {...rest}> |
Member
There was a problem hiding this comment.
Is this prettier formatting? For me it's not as readable, though I defer to you @HelixDesignSystem/helix-react-core
Contributor
Author
There was a problem hiding this comment.
Yes, it is based on the length of the line. It breaks when it exceeds 100 characters: https://github.com/HelixDesignSystem/helix-react/blob/master/prettier.config.js#L4
Member
There was a problem hiding this comment.
Ok thanks @michaelmang. 👍
I wonder if we can change that config...though that's very minor.
nicko-winner
approved these changes
May 18, 2020
Contributor
Author
|
@100stacks all feedback should be addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component: https://helixdesignsystem.github.io/helix-ui/components/drawer/