Merged
Conversation
|
Deploy preview for helix-react ready! Built with commit 2c5553d |
| ...rest | ||
| }) => { | ||
| return ( | ||
| <label className={classNames({ hxChoice: true, className })}> |
Contributor
There was a problem hiding this comment.
non blocking: a potential shorter way to say the same thing:
Suggested change
| <label className={classNames({ hxChoice: true, className })}> | |
| <label className={classNames( 'hxChoice', className)}> |
Contributor
Author
There was a problem hiding this comment.
I think this alternative would add a class name of undefined when there is no className, right?
Contributor
There was a problem hiding this comment.
only if it was written like this: classNames={`hxChoice ${className}`} but className() does not include undefined values.
from the docs: https://github.com/JedWatson/classnames#readme
// other falsy values are just ignored
classNames(null, false, 'bar', undefined, 0, 1, { baz: null }, ''); // => 'bar 1'
added 2 commits
May 18, 2020 18:38
nicko-winner
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://helixdesignsystem.github.io/helix-ui/components/choice-tile/