Merged
Conversation
Added click function to click accept all cookies using css selector Added sleep to wait for accept all cookie popup Updated click for login button css selector
|
Kudos, SonarCloud Quality Gate passed!
|
HellAmbro
reviewed
Feb 8, 2022
| self.driver.find_element_by_name("email").send_keys(username) | ||
| self.driver.find_element_by_name("password").send_keys(password) | ||
| self.driver.find_element_by_class_name("submit-button").click() | ||
| time.sleep(1) #Let the Accept all cookies popup arrive |
Owner
There was a problem hiding this comment.
I think this sleep can be safely deleted.
Contributor
Author
There was a problem hiding this comment.
I'm OK with this. If any issues arise I can report again.
HellAmbro
reviewed
Feb 8, 2022
| class Mode(Enum): | ||
| DEMO = "demo" | ||
| LIVE = "live" | ||
| DEMO = ("demo",) |
Owner
There was a problem hiding this comment.
Why are you using round brackets?
Contributor
Author
There was a problem hiding this comment.
No idea, I think those must have been in the original code, I didn't intentionally add it! They can be removed.
Owner
There was a problem hiding this comment.
Yes, maybe you're using an older version.
HellAmbro
reviewed
Feb 8, 2022
Owner
HellAmbro
left a comment
HellAmbro
left a comment
There was a problem hiding this comment.
Thanks for fixing cookie popup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.