Skip to content

Conversation

@rayd
Copy link
Contributor

@rayd rayd commented May 5, 2016

Not sure if you guys are still active on this project at all, but here are some fixes for the parse function related to the top-level and trailing text nodes. Also fixes #3.

E.g.

parse('<div></div> \n');
parse('<div></div> Something <span>else</span>'

doesn't explode the parser now, and instead it parses as expected.

@fender
Copy link

fender commented Sep 21, 2018

@rayd This fixes the issue for us. Can we merge? We're currently having to fork the repo in order to apply the fix.

@frontmesh
Copy link
Collaborator

frontmesh commented Sep 24, 2018

@rayd This fixes the issue for us. Can we merge? We're currently having to fork the repo in order to apply the fix.

@fender I'll check this PR soon and merge it if everything is good.

@frontmesh frontmesh merged commit f683874 into HenrikJoreteg:master Oct 1, 2018
@fender
Copy link

fender commented Oct 2, 2018

@frontmesh Thanks! Can we have a new tag release so that we can update package.json to point to the updated module? (v1.0.3?)

@frontmesh
Copy link
Collaborator

@fender it has been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explodes with trailing whitespace

3 participants