Use PlayerRespawnEvent instead of PlayerDeathEvent #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroCC
requested changes
Jan 10, 2021
Member
HeroCC
left a comment
HeroCC
left a comment
There was a problem hiding this comment.
Good catch! Must've forgotten to test this one haha. Few small changes if you have the time but overall I'm happy.
HeroCC
approved these changes
Jan 11, 2021
Member
|
Thanks for the contribution, merging! I'll release an update shortly with your changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it works because the plugin couldn't teleport a player that is currently in 'death screen'.
Also added permission multispawn.noteleportondeath because that would be more flexible to make plugin teleport on join but not teleport on death or vice versa.