updated resource label #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsisBagga
requested review from
SHANDCRUZ,
VenkateshRavula,
nabhajit-ray and
yuvirani
SHANDCRUZ
reviewed
Mar 24, 2021
examples/labels.py
Outdated
|
|
||
| config = { | ||
| "ip": "172.16.102.59", | ||
| "ip": "10.1.20.1", |
Contributor
There was a problem hiding this comment.
can you give dummy credentials rather than our dcs credentials?
SHANDCRUZ
approved these changes
Apr 6, 2021
hpeOneView/oneview_client.py
Outdated
| Labels: | ||
| """ | ||
| if not self.__labels: | ||
| '''if not self.__labels: |
Contributor
There was a problem hiding this comment.
you can remove these commented lines (977 to 979)
| """ | ||
| return self._client.get(id_or_uri=id_or_uri) | ||
| uri = self.URI + self.RESOURCES_PATH | ||
| resource_data = self._helper.create(resource, uri=uri, timeout=timeout) |
Contributor
There was a problem hiding this comment.
instead of using the create method in resource_helper class, you can try using it from resource class itself as mentioned below. And you can remove below 2 lines.
return super(Labels, self).create(data, uri=uri, timeout=timeout)
| """ | ||
| uri = self.URI + self.RESOURCES_PATH + '/' + resource_uri | ||
| return self._client.get(id_or_uri=uri) | ||
| return self.get_by_uri(uri) |
Contributor
There was a problem hiding this comment.
we usually use super class as below.
return super(Labels, self).get_by_uri(uri)
VenkateshRavula
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updated resource label
Issues Resolved
[List any issues this PR will resolve. e.g., Fixes #1]
Check List
$ tox).