Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Conversation

@sijeesh
Copy link
Collaborator

@sijeesh sijeesh commented Aug 22, 2019

Remove Pyenv and added both python 2.7 and 3.6 under versions to build the project in both the versions.

Issues Resolved

Fixes: #447

Check List

  • [] New functionality includes testing.
    • All tests pass for Python 2.7+ & 3.4+($ tox).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
    • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

Need to update Python version to "3.4.0", as Travis has removed support for 3.6.
Trying without pyenv
Added Python version - 3.6
Copy link
Collaborator

@jyothisgm jyothisgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sijeesh sijeesh merged commit 850cd23 into release/v4.8.0 Aug 22, 2019
@sijeesh sijeesh deleted the sijeesh-patch-1 branch August 22, 2019 09:04
@sijeesh sijeesh mentioned this pull request Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

my build failed in Travis with the following that I am not sure what to do about...

6 participants