fix(core): improve belonging of point to interval#454
Open
Marthym wants to merge 3 commits intoHipparchus-Math:developfrom
Open
fix(core): improve belonging of point to interval#454Marthym wants to merge 3 commits intoHipparchus-Math:developfrom
Marthym wants to merge 3 commits intoHipparchus-Math:developfrom
Conversation
Contributor
|
Hi there,
Cheers |
Marthym
force-pushed
the
hotfix/improve-belonging-of-point-to-interval-lus
branch
2 times, most recently
from
d819a54 to
1f322be
Compare
The test to determine whether a point belongs to the interval [0,1] is not robust to numerical errors. However, it is necessary to allow points that are slightly outside the bounds. Tests have shown that a numerical error of up to 1e-10 can occur in some cases. fix Hipparchus-Math#460
Marthym
force-pushed
the
hotfix/improve-belonging-of-point-to-interval-lus
branch
from
1f322be to
ca9fe64
Compare
Author
|
Thanks for your review A create the issue #460, add EPSILON constant and add unit test. Regards |
Contributor
|
Thanks. Please write the comments in the code in English tho, not french Another thing I forgot: could you please add your fix in the two changes.xml files: the one in Hipparchus-core and the generic one at library level. Cheers |
added 2 commits
May 4, 2026 12:00
…OneIncluded in SmoothStepFactory
Marthym
force-pushed
the
hotfix/improve-belonging-of-point-to-interval-lus
branch
from
9ed63dc to
e4bfa39
Compare
Author
|
Thanks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test to determine whether a point belongs to the interval [0,1] is not robust to numerical errors. However, it is necessary to allow points that are slightly outside the bounds. Tests have shown that a numerical error of up to 1e-10 can occur in some cases.
ref #460