Add restricted blanket impls for Clone and Debug. Use associated functions.#1
Open
shanecelis wants to merge 5 commits intoHoidigan:mainfrom
Open
Add restricted blanket impls for Clone and Debug. Use associated functions.#1shanecelis wants to merge 5 commits intoHoidigan:mainfrom
shanecelis wants to merge 5 commits intoHoidigan:mainfrom
Conversation
Rust recommends no inherent methods on smart pointers. https://rust-lang.github.io/api-guidelines/predictability.html#c-smart-ptr
Author
|
Bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this package. I had been pondering what a solution for change detection might look like in rust, and I was kind of blown away by how concisely it was captured by your package. I posted about it. In using it, I made some changes.
I added some restricted blanket impls for Clone and Debug along with a doc and test. Rust recommends not having any inherent methods for smart pointers, so I followed their recommendation and converted them to associated functions.
I changed
mutate_silentlytosilent_mut. It seemed more in line with rust's naming conventions.I bumped the minor version number. It's actually a breaking change and should technically require a major version number bump but often for young packages it seems too early to bump the major one.