Conversation
Contributor
|
Looks like the merge won't be bad. I've addressed all comments on #81 now and my current work is in https://github.com/HolyLab/BlockRegistration/tree/cjg/qd_trans_aff2 which I'll rebase after you merge this. I also want to write up some of my observations as to why |
Member
Author
|
OK, I'll merge. Happy to help anyone overcome tricky conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just putting this up so that folks can see whether this will cause trouble. I also put a limit on function evaluations in
qd_rigidbecause those tests were taking a lot of time (esp. on a second run, where most of the rest of the tests are really fast).