Conversation
youdongguo
commented
Feb 5, 2026
youdongguo
commented
Feb 5, 2026
youdongguo
commented
Feb 5, 2026
youdongguo
commented
Feb 5, 2026
Co-authored-by: Tim Holy <tim.holy@gmail.com>
timholy
reviewed
Feb 19, 2026
Member
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
This looks pretty good, just minor details. The actual code itself is largely fine.
.vscode/settings.json
Outdated
| @@ -1 +1,3 @@ | |||
| {} No newline at end of file | |||
| { | |||
| "julia.environmentPath": "/Users/youdongguo/.julia/dev/GsvdInitialization" | |||
Member
There was a problem hiding this comment.
This file shouldn't be committed to the repository. Tip: I have this locally:
tim@hypnotic:~$ cat .gitignore_global
repl_history.jl
settings.jsonThat ensures I never commit either settings.json or repl_history.jl to a package.
| end | ||
| gaussiantemplate(r::Real) = gaussiantemplate(Float64, r) | ||
|
|
||
| load_svd_of_gt() = load(joinpath(dirname(@__DIR__), "demo/svd_of_GT.jld2"))["svdX"] |
Member
There was a problem hiding this comment.
This will surely need some comment about why we are uploading it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not ready for review