fix: zsh completions for old cask names

[tiluckdave]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Fixes #20056

Made a new file in the cache_dir containing old cask names as well, so as not to disturb the brew casks command. Updated the completions logic to take it from the new file if it exists, or else defaults to brew casks.

[MikeMcQuaid]

Thanks for the PR @tiluckdave!

@Homebrew/maintainers interested in thoughts on this. I'd rather we didn't write another file here but I don't think it makes for brew casks (or even completions, honestly) to handle the old names. Thoughts?

[EricFromCanada]

If such a feature is to be added, it should be done for bash/fish/zsh and for both formulae and casks. Also, instead of generating a new file with cask's current and old names mixed together, why not implement something similar to how formula_aliases.txt is generated and read? Also, is it possible for tab completion to auto-correct to the new name when completing the old name?

[tiluckdave]

@EricFromCanada @MikeMcQuaid

I can update this for formulae as well as on bash/zsh/fish. But first, let me explore whether we can autocomplete to a new name. If I find something, I will share my approach here.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.