Skip to content

Conversation

@ychin
Copy link
Contributor

@ychin ychin commented Aug 19, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Add gettext dependency to make sure MacVim supports localization. See macvim-dev/macvim#1070 which added support for that.

Version 165 added gettext support, and as such add the dependency to
MacVim formula.
@BrewTestBot BrewTestBot added lua Lua use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue labels Aug 19, 2020
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ychin ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Contributor

🤖 A scheduled task has triggered a merge.

@ychin ychin deleted the macvim-8.2-165-gettext branch December 11, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lua Lua use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants