Open
Conversation
replaced int with npy_intp for lag parameters in _pyarray_correlate and related functions renamed lagvector input to correlate() and convolve() to be named return_lags
this is to keep in line with commit bac2fdf
_pyarray_correlate ignores minlag, maxlag, and lagstep for modes other than 3
…le.c Removed correlate and corresponding array_correlate from multiarraymodule.c Reason: old_behavior has been deprecated from correlate and convolve in numeric.py Also: - restore PyArray_Correlate and PyArray_Correlate2 signatures - add bounds checking to maxlag and minlag in _pyarray_correlate. - minor cleanups in correlate/convolve code.
Conflicts: doc/source/reference/c-api.array.rst numpy/core/numeric.py numpy/core/tests/test_numeric.py
… to C-style guide
…() in multiarraymodule.c, created _lags_from_mode() to compensate
…g with a new lags argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test