Draft
Conversation
still need to: - fix correlatemode_parser and PyArray_CorrelatemodeConverter in core/src/multiarray/conversion_utils.c - fix array_correlate and array_correlate2 in core/src/multiarray/multiarraymodule.c based on those fixes and based on maxlag PR
…e.c changes from maxlag branch, requiring changes to conversion_utils.c and ndarratypes.h
yinnonsanders
commented
Jun 26, 2023
| # Version 17 (NumPy 1.25) No actual change. | ||
| 0x00000011 = ca1aebdad799358149567d9d93cbca09 | ||
|
|
||
| # Version 18 (NumPy 1.24) Added PyArray_CorrelateLags. |
Collaborator
Author
There was a problem hiding this comment.
Update version when rebasing (now on version 2.0.0)
| 'PyDataMem_SetHandler': (304, MinVersion("1.22")), | ||
| 'PyDataMem_GetHandler': (305, MinVersion("1.22")), | ||
| # End 1.22 API | ||
| 'PyArray_CorrelateLags': (307, MinVersion("1.25")), |
Collaborator
Author
There was a problem hiding this comment.
Formatting, also fix version when rebasing.
| if type(lag) is int: # maxlag | ||
| lags = (-lag+1, lag, 1) | ||
| elif type(lag) is tuple: # minlag and maxlag | ||
| if len(lag) > 2: |
Collaborator
Author
There was a problem hiding this comment.
Add check for length of 3?
| # 0x00000011 - 1.25.x | ||
| C_API_VERSION = 0x00000011 | ||
| # 0x00000012 - 1.26.x | ||
| C_API_VERSION = 0x00000012 |
Collaborator
Author
There was a problem hiding this comment.
Fix version when rebasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.