Skip to content

Apparent hashing of duplicated information in InnerProductArgPC::setup() function #21

@95DDB

Description

@95DDB

Currently, when generating the committer key, we also hash the max degree along with the generators (https://github.com/HorizenLabs/poly-commit/blob/dev/src/ipa_pc/mod.rs#L684):

let hash = D::digest(&to_bytes![&generators, max_degree as u32].unwrap()).to_vec();

It seems to me we are hashing a duplicated information, since already generators.len() == max_degree.
Can we remove it from the hash ?

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions