Skip to content

Fix URL.searchParams cannot find function #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbri merged 5 commits into from
Aug 31, 2021
Merged

Fix URL.searchParams cannot find function #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b3b20a
Merge pull request #1 from HtmlUnit/master
cdalexndr Jan 3, 2021
89d9ac7
Merge pull request #2 from HtmlUnit/master
cdalexndr Jan 9, 2021
13ba964
Merge pull request #3 from HtmlUnit/master
cdalexndr Apr 23, 2021
3916581
Merge branch 'HtmlUnit:master' into master
cdalexndr Aug 30, 2021
7416e86
fix URL.searchParams cannot find function
cdalexndr Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/gargoylesoftware/htmlunit/javascript/host/URL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,10 @@ public URLSearchParams getSearchParams() {
return null;
}

return new URLSearchParams(url_.getQuery());
URLSearchParams searchParams = new URLSearchParams(url_.getQuery());
searchParams.setParentScope(getParentScope());
searchParams.setPrototype(getPrototype(searchParams.getClass()));
return searchParams;
}

/**
Expand Down
16 changes: 16 additions & 0 deletions src/test/java/com/gargoylesoftware/htmlunit/javascript/host/URLSearchParamsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,11 @@ public void getAll() throws Exception {
*/
@Test
@Alerts(DEFAULT = {"key1=val1&key2=val2&key2=val3&key4=val4",
"key1=new1&key2=val2&key2=val3&key4=val4",
"key1=new1&key2=new2&key4=val4",
"key1=new1&key2=new2&key4=val4&key3=undefined",
"key1=new1&key2=new2&key4=null&key3=undefined",
"key1=val1&key2=val2&key2=val3&key4=val4",
"key1=new1&key2=val2&key2=val3&key4=val4",
"key1=new1&key2=new2&key4=val4",
"key1=new1&key2=new2&key4=val4&key3=undefined",
Expand All @@ -373,6 +378,17 @@ public void set() throws Exception {
+ " alert(param);\n"
+ " param.set('key4', null);\n"
+ " alert(param);\n"
+ " param = new URL('http://test.com/p?key1=val1&key2=val2&key2=val3').searchParams;\n"
+ " param.set('key4', 'val4');\n"
+ " alert(param);\n"
+ " param.set('key1', 'new1');\n"
+ " alert(param);\n"
+ " param.set('key2', 'new2');\n"
+ " alert(param);\n"
+ " param.set('key3', undefined);\n"
+ " alert(param);\n"
+ " param.set('key4', null);\n"
+ " alert(param);\n"
+ " }\n"
+ " }\n"
+ " </script>\n"
Expand Down