Skip to content

Conversation

@cdalexndr
Copy link
Contributor

@cdalexndr cdalexndr commented Aug 31, 2021

Changes to URL.searchParams reflect back to original url.

Depends on: #375, or else test fails with cannot find function error

@cdalexndr cdalexndr changed the title Reflext changes tu URL.searchParams back to URL Reflect changes tu URL.searchParams back to URL Aug 31, 2021
@cdalexndr cdalexndr changed the title Reflect changes tu URL.searchParams back to URL Reflect changes to URL.searchParams back to URL Aug 31, 2021
@rbri
Copy link
Member

rbri commented Aug 31, 2021

As always many thanks fr the contribution. Will have a look at the others during the next days.

Btw: it will be really great if we can use your real name for the author tag

@rbri
Copy link
Member

rbri commented Sep 5, 2021

Hi,
i have done a different implementation for this because i do not want to get more HttpClient dependencies. But hopefully your cases are also solved now.
There is still a problem with all the encoding - have to work on this during the next days.

It will be great if you can have a look at my changes and maybe make a new pr with more test cases for this area (and maybe fixes also).

And again thanks a lot for your contributions.

@rbri rbri closed this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants