Adding new features to hapipy #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough tests for contacts and lists to hapipy/test
…ugh tests for contacts and lists.
hapi/contacts.py
Outdated
| class ContactsClient(BaseClient): | ||
| """ | ||
| This client and its respective API are under active development and therefore should | ||
| not be considered stable for use in any production environments. - CODonnell - 11.21.11 |
There was a problem hiding this comment.
If this is getting pulled into hapipy, it is probably stable for production, no?
|
nick and i left a bunch of feedback. please review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding contacts, lists, groups, and properties to hapipy from hapi_plus. Also adding rough tests for contacts and lists.