feat: Add migration for existing project #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jy/migrate-existing-project
…-existing-project
kemmerle
reviewed
Apr 15, 2025
kemmerle
reviewed
Apr 15, 2025
kemmerle
reviewed
Apr 15, 2025
kemmerle
reviewed
Apr 15, 2025
camden11
previously approved these changes
Apr 15, 2025
| @@ -1,3 +1,4 @@ | |||
| // @ts-nocheck | |||
Contributor
There was a problem hiding this comment.
Just curious why the ts-nocheck is even needed - doesn't seem like there would be any type issues with an object literal like this
kemmerle
reviewed
Apr 15, 2025
kemmerle
previously approved these changes
Apr 15, 2025
Contributor
kemmerle
left a comment
kemmerle
left a comment
There was a problem hiding this comment.
I left a few comments, mostly nits. I do think you should leave some comments in handleMigrationSetup for posterity before merging.
kemmerle
previously approved these changes
Apr 15, 2025
brandenrodgers
previously approved these changes
Apr 16, 2025
…-existing-project
brandenrodgers
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Adds
hs project migrateto migrate an existing project from2023.2tounstableTo test:
2023.2and cd into the project dirctoryyarn hs project migrateuidsenter them{project-location}/archiveand your new source code will be located in{project-location}/{project-source-dir}. Thehsproject.jsonfile should be updated to have the correct platform version