Fix dev test account creation #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
joe-yeager and
kemmerle
as code owners
joe-yeager
previously approved these changes
Apr 23, 2025
Contributor
joe-yeager
left a comment
joe-yeager
left a comment
There was a problem hiding this comment.
LGTM, just a minor nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Relies on HubSpot/hubspot-local-dev-lib#261
This fixes the double prompt that we get during project local dev if you opt to create a new dev test account. The api returns a personal access key, so there's no need for us to be re-prompting users for it.
This is a regression that I accidentally introduced a little while ago.
Screenshots
TODO
Who to Notify