Hide sandbox prompt for accounts with no sandbox access #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
joe-yeager and
kemmerle
as code owners
joe-yeager
previously approved these changes
Apr 23, 2025
Contributor
joe-yeager
left a comment
joe-yeager
left a comment
There was a problem hiding this comment.
LGTM, just a nit about nesting.
Comment on lines
83
to
92
| if (isDeveloperTestAccount(accountConfig)) { | ||
| bypassRecommendedAccountPrompt = true; | ||
| } else if (!hasPublicApps) { | ||
| if (isSandbox(accountConfig)) { | ||
| bypassRecommendedAccountPrompt = true; | ||
| } else { | ||
| const defaultAccountHasSandboxes = await hasSandboxes(accountConfig); | ||
| bypassRecommendedAccountPrompt = !defaultAccountHasSandboxes; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isDeveloperTestAccount(accountConfig)) { | |
| bypassRecommendedAccountPrompt = true; | |
| } else if (!hasPublicApps) { | |
| if (isSandbox(accountConfig)) { | |
| bypassRecommendedAccountPrompt = true; | |
| } else { | |
| const defaultAccountHasSandboxes = await hasSandboxes(accountConfig); | |
| bypassRecommendedAccountPrompt = !defaultAccountHasSandboxes; | |
| } | |
| } | |
| if (isDeveloperTestAccount(accountConfig)) { | |
| bypassRecommendedAccountPrompt = true; | |
| } else if (!hasPublicApps && isSandbox(accountConfig)) { | |
| bypassRecommendedAccountPrompt = true; | |
| } else if (!hasPublicApps) { | |
| const defaultAccountHasSandboxes = await hasSandboxes(accountConfig); | |
| bypassRecommendedAccountPrompt = !defaultAccountHasSandboxes; | |
| } |
Nit: We can reduce nesting by one layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
When testing legacy private app local dev on an account without sandboxes, I noticed that we still showed the sandbox prompt but the only option was to proceed with your current account. This replaces that prompt with the more generic prompt we show when your default account fits the recommended requirements (i.e. is a sandbox or dev test account).
I also updated the copy of the prompt to be more in line with the rest of the language we use in
hs project devScreenshots
Before
After
Who to Notify
@brandenrodgers @joe-yeager @kemmerle