Support legacy public app development in combined accounts #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
changed the title
camden11
requested review from
brandenrodgers,
joe-yeager and
kemmerle
as code owners
joe-yeager
approved these changes
Apr 23, 2025
Comment on lines
+88
to
+91
| export const FEATURES = { | ||
| UNIFIED_THEME_PREVIEW: 'cms:react:unifiedThemePreview', | ||
| UNIFIED_APPS: 'Developers:UnifiedApps:PrivateBeta', | ||
| } as const; |
Contributor
There was a problem hiding this comment.
Thanks for moving these here 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Previously, converting a developer account to a combined account meant losing the ability to run
hs project devon legacy public apps. This is because a combined account is technically a standard account, whichhs project devdidn't support for public apps. This updates the logic in the legacy dev flow to allow unified apps (and also updates the legacyclone-appandmigrate-appcommands to work with combined accounts)See https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/806
Who to Notify
@brandenrodgers @kemmerle @joe-yeager