chore: Add --network-debug flag to log all http requests from LDL #1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
joe-yeager
commented
Apr 25, 2025
lib/commonOpts.ts
Outdated
| .option('network-debug', { | ||
| default: false, | ||
| type: 'boolean', | ||
| hidden: true, |
Contributor
Author
There was a problem hiding this comment.
I don't see a compelling reason to unhide this. If we think external users want to use it, I can add some copy and unhide it. It's realistically more for our benefit
kemmerle
previously approved these changes
Apr 25, 2025
joe-yeager
commented
Apr 25, 2025
| it('should support the correct options', () => { | ||
| createCommand.builder(yargs); | ||
|
|
||
| expect(yargs.option).toHaveBeenCalledTimes(3); |
Contributor
Author
There was a problem hiding this comment.
This was a fragile assertion, so I felt it was better to remove it than increment the number
kemmerle
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Add a hidden
--network-debugflag that sets the log level to debug and setsHUBSPOT_NETWORK_LOGGINGto true so LDL will log http traffic