fix: Add polling error handling after begin migration #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
| SpinniesManager.fail('beginningMigration', { | ||
| text: lib.migrate.spinners.unableToStartMigration, | ||
| }); | ||
| if (isMigrationStatus(error) && error.status === MIGRATION_STATUS.FAILURE) { |
Contributor
There was a problem hiding this comment.
Not a blocker, but we do have isSpecifiedError in LDL that you could use here (doesn't buy you a ton tbh, outside of maybe consistency in util usage)
Contributor
Author
There was a problem hiding this comment.
Good question. These aren't actually Error objects, our polling util rejects with plain objects that look like:
{
status: "FAILURE" | "SOME_OTHER_STATUS"
... other fields
}
Wheres isSpecifiedError only operates on HubSpotHttpErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Log the error message in the event that the polling returns a failure after the begin migration