chore: Inline the remaining files #1470
Conversation
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
| async diagnose(): Promise<DiagnosticInfo> { | ||
| SpinniesManager.add('runningDiagnostics', { | ||
| text: i18n(`${i18nKey}.runningDiagnostics`), | ||
| text: i18n(`lib.doctor.runningDiagnostics`), |
There was a problem hiding this comment.
Cursor seemed to have a hard time with this file. It wanted to inline them like this: ${'lib.doctor'}.runningDiagnostics, so I would pay extra special attention to this file.
| message: i18n(`${i18nKey}.enterFolder`), | ||
| message: i18n(`lib.prompts.createFunctionPrompt.enterFolder`), | ||
| validate(val?: string) { | ||
| if (typeof val !== 'string') { |
There was a problem hiding this comment.
This is outside the scope of this prompt, but we repeat the same validate function three times with the same i18n strings--can we combine into one function?
There was a problem hiding this comment.
I'm going to leave that alone for a later refactoring. I want this PR to focus solely on inlining the strings and not refactoring anything. These are already really large PRs so I'm trying to limit risk as much as possible and keep them targeted and easy to review.
|
|
||
| exports.command = 'lighthouse-score [--theme]'; | ||
| exports.describe = false; // i18n(`${i18nKey}.describe`); | ||
| exports.describe = false; |
There was a problem hiding this comment.
I think we can unhide this command now. Maybe check with @brandenrodgers
There was a problem hiding this comment.
The last time this came up, the answer was to let the CMS team determine the future of the commands. I'm not sure where they landed on it
kemmerle
left a comment
kemmerle
left a comment
There was a problem hiding this comment.
Some minor comments but otherwise, looks good to me!
Description and Context
In the remaining keys in preparation for the switch