chore: Add tests for the migration flow #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
changed the title
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
| - Type definitions in separate `/types` directory | ||
| - Never commit or push to main branch without permission | ||
| - Never commit or push to main branch without permission | ||
| - Skipping tests is never a valid solution to fixing them |
Contributor
Author
There was a problem hiding this comment.
Haha yeah, Claude had some creative ideas about how to fix the tests
brandenrodgers
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Add tests for the migration command and the libs