chore: Add migration warning #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
commented
May 1, 2025
joe-yeager
commented
May 1, 2025
| borderStyle: 'round', | ||
| }; | ||
|
|
||
| export async function logInBox({ |
Contributor
Author
There was a problem hiding this comment.
I figured it made sense to make a wrapper around this so we don't need to repeat the same options and dynamic import in multiple places.
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
kemmerle
previously approved these changes
May 2, 2025
Contributor
kemmerle
left a comment
kemmerle
left a comment
There was a problem hiding this comment.
Code looks clean, and I like the warning design! 
lib/ui/boxen.ts
Outdated
| export async function logInBox({ | ||
| contents, | ||
| options, | ||
| fallBackToNoBox = false, |
Contributor
There was a problem hiding this comment.
I love this variable name lol, but I'd also be fine with removing it and always falling back to no box. Or defaulting to true. We should probably be falling back to no box in the fire alarm middleware too.
Contributor
Author
There was a problem hiding this comment.
Haha, I had such a hard time naming it. I'll make it fallback by default and remove this. I think it makes sense that we would probably want to have a fallback in place at all times.
brandenrodgers
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Add a more explicit migration warning for projects: