Fix local dev logger bug #1478
Merged
Fix local dev logger bug #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
joe-yeager and
kemmerle
as code owners
joe-yeager
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
When I updated the CLI to use the new
uiLoggerrather thanloggerfrom local dev lib, I accidentally passeduiLoggerto the UIE dev server as well, which breaks local dev.Todo
It would be nice to get the CLI and UIE dev server to share types for the dev mode interface - would help prevent bugs like this from happening in the future. This would require a bit of a lift in both repos though, so going to hold off on doing that now.
Who to Notify
@brandenrodgers @kemmerle @joe-yeager