port cms lighthouse-score to TS (waiting for LDL release) #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
joe-yeager and
kemmerle
as code owners
brandenrodgers
changed the title
brandenrodgers
changed the title
camden11
previously approved these changes
May 9, 2025
|
|
||
| const getTableData = (target, scoreResult) => { | ||
| const scores = scoreResult.scores ? scoreResult.scores[0] : {}; | ||
| const getTableData = ( |
joe-yeager
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
porting
hs cms lighthouse-scoreto TS.This relies on an LDL PR: HubSpot/hubspot-local-dev-lib#268
Screenshots
TODO
Who to Notify