chore: Port the fetch command to ts #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-yeager
requested review from
brandenrodgers,
camden11 and
kemmerle
as code owners
joe-yeager
commented
May 9, 2025
| options | ||
| { | ||
| assetVersion: | ||
| assetVersion !== undefined ? `${assetVersion}` : assetVersion, |
Contributor
Author
There was a problem hiding this comment.
This is type: number and optional and it needs to be converted to string | undefined
joe-yeager
commented
May 9, 2025
commands/fetch.ts
Outdated
| type FetchCommandArgs = { | ||
| src: string; | ||
| dest?: string; | ||
| derivedAccountId?: number; |
Contributor
There was a problem hiding this comment.
Nit, but don't need derivedAccountId in here anymore since it's defined in CommonArgs
brandenrodgers
previously approved these changes
May 9, 2025
Contributor
brandenrodgers
left a comment
brandenrodgers
left a comment
There was a problem hiding this comment.
Just a nit about a duplicate type definition, but otherwise lgtm 👌
brandenrodgers
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Port the fetch command to TS