Fix: Bugs in account commands
#1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
brandenrodgers
previously approved these changes
May 12, 2025
Contributor
brandenrodgers
left a comment
brandenrodgers
left a comment
There was a problem hiding this comment.
Code lgtm. Just left one suggestion to make the error more concise
brandenrodgers
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This PR addresses bugs that I discovered when testing out this LDL PR, although the two do not rely on one another.
It fixes an issue with
hs account remove. If your default account were set to the account ID (1234567), but you removed the account using itsname(ie.hs account remove accountName), we were not properly prompting users to choose another default account.Both
hs account create-overrideandhs account remove-overridedid not properly warn customers that the commands require a global config file.Screenshots
New error message for
overridecommands:TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager