Refactor: Improve migration flow #1512
Conversation
package.json
Outdated
| "repository": "https://github.com/HubSpot/hubspot-cli", | ||
| "dependencies": { | ||
| "@hubspot/local-dev-lib": "3.5.6", | ||
| "@hubspot/local-dev-lib": "0.3.1-experimental.0", |
There was a problem hiding this comment.
Need to bump this, after the sister LDL PR is merged.
| !configFileExists(true) && | ||
| isTargetedCommand(argv._, { | ||
| account: { target: false, subCommands: { auth: { target: true } } }, | ||
| config: { target: false, subCommands: { migrate: { target: true } } }, |
There was a problem hiding this comment.
If the hs config migrate command is validated and there is no deprecated config present, we warn the user that they need to supply an account ID. That would be ok for any other command, but with this command, we want to tell the user that no further action is required because the migration has already taken place.
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
We're doing this prompt differently from how we do all of our other prompts. Making the entire thing bold is a little overwhelming IMO. In out other prompts, the only content in the actual prompt itself is the question. All of the other context goes above the prompt as a standard CLI log statement. Example (not a great one, but the best I could quickly find): We should put all the From/To context above the prompt as a standard CLI log, and then the prompt message should be something simple like: |
|
@brandenrodgers, I refactored the prompts per your suggestions: New migration prompt (Appears in both 
New merge prompt (Appears in both 
|
Description and Context
(Draft because I'm currently experiencing issues with the API service; will mark as ready for review when those are addressed)
This PR relies on this LDL PR. I've created an experimental release of LDL for ease of testing.
This PR gives more detailed messaging about the migration/merge process to the global config file in the
hs config migrateandhs account authcommands.Screenshots
New migration prompt (Appears in both
hs config migrateandhs account authwhen deprecated config is present):New merge prompt (Appears in both
hs config migrateandhs account authwhen both configs are present):New verbose description of
hs config migrate:New verbose description of
hs account auth:TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager