Setup local dev websocket server #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
joe-yeager and
kemmerle
as code owners
joe-yeager
reviewed
May 14, 2025
Comment on lines
+97
to
+100
| this.server.on('connection', ws => { | ||
| this._websocket = ws; | ||
| this.setupMessageHandlers(); | ||
| }); |
Contributor
There was a problem hiding this comment.
I think this might be problematic for multiple connections. Anytime a new connection is made, I believe it will overwrite the previous connection. So if the user were to have multiple local dev page tabs open, only the most recent tab would have a functioning websocket connection.
Edit: Actually, I think it will still get messages, we just won't have a way to reference it. I think we might want to make this a list of websockets.
Contributor
Author
There was a problem hiding this comment.
Ohhh this is a good callout. I didn't test beyond one connection. I'll address this in another PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This does the initial setup work for the
LocalDevWebsocketServerand adds project upload functionality as an example of how it will work. It's still a work in progress, so leaving it commented out for now.Screenshots
https://hubspot.slack.com/archives/C076QV345ME/p1747160870258469
TODO
The rest of the
LocalDevWebsocketServerwork will be added in follow up PRs. The next step is probably to updateLocalDevStateto be immutable, and to establish a pattern forLocalDevProcessand the dev servers to interact with the server.Testing
If you want, you can test this out using Postman or Insomnia or something similar.
unifiedFlow.tshs project devhs project devwith--debugand looking at the logs, or by hitting the port manager serverlocalhost:8000/serversWho to Notify
@brandenrodgers @kemmerle @joe-yeager