Support project profiles #1520
Support project profiles #1520
Conversation
brandenrodgers
requested review from
camden11,
joe-yeager and
kemmerle
as code owners
| logProfileFooter(profile); | ||
| } else { | ||
| // A profile must be specified if this project has profiles configured | ||
| await exitIfUsingProfiles(projectConfig, projectDir); |
There was a problem hiding this comment.
For all of the commands that leverage profiles. We will exit if you have profiles configured AND you don't specify a profile for the command. It has to be explicitly provided
| return false; | ||
| } | ||
|
|
||
| export function fileExists(_path: string): boolean { |
There was a problem hiding this comment.
I made some edits to this so I could use it in my new commands. I didn't want to include the logs. Nothing was calling this function except for checkAndConvertToJson so this should be a safe change. I tested it on the commands that use checkAndConvertToJson and everything seems to WAD
| let targetAccountId: number | undefined; | ||
|
|
||
| try { | ||
| const profileToRemove = loadHsProfileFile(projectSourceDir, profileName); |
There was a problem hiding this comment.
Intentionally not using loadProfile here because I don't want any of the logs if it fails to load. I'm loading it because it lets us prompt the user to remove the project from the account if we can find the accountId in it.
|
|
||
| if (profileToCopyVariablesFrom) { | ||
| try { | ||
| const profileToCopyFileContent = loadHsProfileFile( |
There was a problem hiding this comment.
Not using loadProfile here because we don't want to log anything on errors. We'll make the variables section in the new config empty if this fails.
Description and Context
An initial pass at supporting project profiles. Depends on some changes to the project parsing lib.
Screenshots
TODO
Who to Notify