Support dev on dev sandbox accounts if the portal has access #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
changed the title
joe-yeager
approved these changes
May 30, 2025
Contributor
joe-yeager
left a comment
joe-yeager
left a comment
There was a problem hiding this comment.
Code LGTM, just a non-blocking nit about splitting the logic up
Comment on lines
+131
to
+158
| if (accountType === HUBSPOT_ACCOUNT_TYPES.DEVELOPER_TEST) { | ||
| const devAccountPromptResponse = | ||
| await selectDeveloperTestTargetAccountPrompt(accounts!, accountConfig); | ||
|
|
||
| targetTestingAccountId = devAccountPromptResponse.targetAccountId; | ||
|
|
||
| if (!!devAccountPromptResponse.notInConfigAccount) { | ||
| // When the developer test account isn't configured in the CLI config yet | ||
| // Walk the user through adding the account's PAK to the config | ||
| await useExistingDevTestAccount( | ||
| env, | ||
| devAccountPromptResponse.notInConfigAccount | ||
| ); | ||
| } else if (devAccountPromptResponse.createNestedAccount) { | ||
| // Create a new developer test account and automatically add it to the CLI config | ||
| targetTestingAccountId = await createDeveloperTestAccountForLocalDev( | ||
| targetProjectAccountId, | ||
| accountConfig, | ||
| env | ||
| ); | ||
| } | ||
| } else if (accountType === HUBSPOT_ACCOUNT_TYPES.DEVELOPMENT_SANDBOX) { | ||
| const sandboxAccountPromptResponse = | ||
| await selectSandboxTargetAccountPrompt(accounts!, accountConfig); | ||
|
|
||
| targetTestingAccountId = sandboxAccountPromptResponse.targetAccountId; | ||
| } else { | ||
| targetTestingAccountId = targetProjectAccountId; |
Contributor
There was a problem hiding this comment.
Non-blocking nit: This section might benefit from a refactor to split this up into smaller pieces.
Contributor
Author
There was a problem hiding this comment.
I may hold off and let Camden break this up however he wants to when he gets back. He was another WIP pr that touches this code too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Add support for selecting dev sandbox accounts during the
hs project devinit flow if the user's account has access to them. There are quite a few permutations to highlight for this. I'll try to call out the most important flows.Previously we were requiring that the default account was a developer account or a standard account in order to run local dev for unified apps. This was an attempt to make sure that the account was opted in to leverage some of the new flows. Now we have a gate checks for it, so we use that instead.
If the user provides
--account, we'll make the project account and the testing account the same thing. i.e. we'll upload the project to the same account that we're testing on. Longer term we're thinking about splitting this arg into something along the lines oftargetProjectAccountandtargetTestingAccountto give more flexibility.Screenshots
TODO
Who to Notify