Allow isOpen to be controlled by the parent component#1
Merged
TrevorBurnham merged 1 commit intomasterfrom Feb 24, 2016
Merged
Conversation
This change does not prevent onOpen/onClose events from firing.
|
Seems reasonable. I think the events firing will be ok still. |
TrevorBurnham
added a commit
that referenced
this pull request
Feb 24, 2016
Allow isOpen to be controlled by the parent component
4 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@colbyr This PR adds an
isOpenprop that overridesstate.isOpen. This struck me as the simplest change that would allow us to control the open state from the parent component. The one drawback is that input events still triggeronOpen/onClose. If that turns out to be a problem, we can add more logic to prevent that from happening.