README: markdown formatting in the "Further Options" table#60
Closed
aceyoung9 wants to merge 1 commit intoHubSpot:masterfrom
aceyoung9:master
Closed
README: markdown formatting in the "Further Options" table#60aceyoung9 wants to merge 1 commit intoHubSpot:masterfrom aceyoung9:master
aceyoung9 wants to merge 1 commit intoHubSpot:masterfrom
aceyoung9:master
Conversation
…ble, such that table can render on Github.com interface.
Contributor
|
Thanks a ton for the PR! Though it looks like this was also broken in the upstream and fixed recently by JedWatson/react-select@14f199c#diff-04c6e90faac2675aa89e2176d2eec7d8 I imagine we'll want to pick that up when the next release comes out to avoid potential conflicts, but defer to @TrevorBurnham on that one. |
Contributor
|
Yes, this was fixed by an upstream change, which has been merged as part of #62. Thanks! |
Author
|
Cool thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: