Skip to content

Enable displaying of custom logos for companies/institutions #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcushen merged 17 commits into from
Oct 21, 2025
Merged

Enable displaying of custom logos for companies/institutions #3282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7202991
Add option to display logos
olipinski Oct 20, 2025
9b266f0
Apply suggestion from @olipinski
gcushen Oct 21, 2025
04682b0
Apply suggestion from @gcushen
gcushen Oct 21, 2025
fcc9034
Apply suggestion from @gcushen
gcushen Oct 21, 2025
051fc99
Apply suggestion from @gcushen
gcushen Oct 21, 2025
cde97b4
Apply suggestion from @gcushen
gcushen Oct 21, 2025
6086acd
Apply suggestion from @gcushen
gcushen Oct 21, 2025
cb98167
Apply suggestion from @gcushen
gcushen Oct 21, 2025
cb4fa03
Apply suggestion from @gcushen
gcushen Oct 21, 2025
c6d3468
Apply suggestion from @gcushen
gcushen Oct 21, 2025
70201fd
Apply suggestion from @gcushen
gcushen Oct 21, 2025
df72a88
Apply suggestion from @gcushen
gcushen Oct 21, 2025
a2eeba0
Apply suggestion from @gcushen
gcushen Oct 21, 2025
d7cf64e
Apply suggestion from @gcushen
gcushen Oct 21, 2025
b3ec378
Apply suggestion from @gcushen
gcushen Oct 21, 2025
26844e7
Apply suggestion from @gcushen
gcushen Oct 21, 2025
f409738
Apply suggestion from @gcushen
gcushen Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modules/blox-tailwind/blox/resume-biography-3/block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,12 @@ <h3 class="text-xl sm:text-2xl lg:text-3xl font-bold text-gray-900 dark:text-whi
{{ range . }}
<div class="group h-full flex flex-col bg-gradient-to-br from-white/90 to-primary-50/30 dark:from-gray-800/90 dark:to-primary-900/20 rounded-xl p-6 shadow-md hover:shadow-xl transition-all duration-300 border border-transparent hover:border-primary-200 dark:hover:border-primary-800 backdrop-blur-md">
<div class="flex gap-4">
<div class="flex-shrink-0 w-12 h-12 bg-primary-600 rounded-full flex items-center justify-center shadow-md">
{{ partial "functions/get_icon" (dict "name" "academic-cap" "attributes" "class='w-6 h-6 text-white'") }}
<div class="flex-shrink-0 w-12 h-12 bg-white dark:bg-gray-800 ring-1 ring-gray-200 dark:ring-gray-700 rounded-full flex items-center justify-center shadow-md">
{{ if .icon }}
{{ partial "functions/get_icon" (dict "name" .icon "attributes" "class='w-6 h-6 text-primary-600 dark:text-primary-400'") }}
{{else}}
{{ partial "functions/get_icon" (dict "name" "academic-cap" "attributes" "class='w-6 h-6 text-primary-600 dark:text-primary-400'") }}
{{end}}
Copy link
Copy Markdown

@cursor cursor Bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Icon Contrast Issue in Light Mode

The icon container's background was updated from bg-primary-600 (dark) to bg-primary-200 (light). However, the fallback academic-cap icon still uses text-white, causing poor contrast and making it nearly invisible in light mode when no custom institution_logo is provided. This also creates an inconsistency with custom icons.

Fix in Cursor Fix in Web

</div>
<div class="flex-1 flex-grow">
<p class="text-xl font-bold text-gray-900 dark:text-white group-hover:text-primary-600 dark:group-hover:text-primary-400 transition-colors">
Expand Down
11 changes: 9 additions & 2 deletions modules/blox-tailwind/blox/resume-experience/block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ <h3 class="mb-6 text-3xl font-bold text-gray-900 dark:text-white text-center">{{
{{ range $idx, $key := $person.work }}
<li class="mb-10 ms-6">
<span class="absolute flex items-center justify-center w-6 h-6 bg-primary-100 rounded-full -start-3 ring-8 ring-white dark:ring-gray-900 dark:bg-primary-900">
<svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 256 256" class="w-5 h-5 text-primary-800 dark:text-primary-300"><path d="M216,56H176V48a24,24,0,0,0-24-24H104A24,24,0,0,0,80,48v8H40A16,16,0,0,0,24,72V200a16,16,0,0,0,16,16H216a16,16,0,0,0,16-16V72A16,16,0,0,0,216,56ZM96,48a8,8,0,0,1,8-8h48a8,8,0,0,1,8,8v8H96ZM216,72v41.61A184,184,0,0,1,128,136a184.07,184.07,0,0,1-88-22.38V72Zm0,128H40V131.64A200.19,200.19,0,0,0,128,152a200.25,200.25,0,0,0,88-20.37V200ZM104,112a8,8,0,0,1,8-8h32a8,8,0,0,1,0,16H112A8,8,0,0,1,104,112Z"></path></svg>
{{ if .icon }}
{{ partial "functions/get_icon" (dict "name" .icon "attributes" "class='w-5 h-5'") }}
{{else}}
<svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 256 256" class="w-5 h-5 text-primary-800 dark:text-primary-300"><path d="M216,56H176V48a24,24,0,0,0-24-24H104A24,24,0,0,0,80,48v8H40A16,16,0,0,0,24,72V200a16,16,0,0,0,16,16H216a16,16,0,0,0,16-16V72A16,16,0,0,0,216,56ZM96,48a8,8,0,0,1,8-8h48a8,8,0,0,1,8,8v8H96ZM216,72v41.61A184,184,0,0,1,128,136a184.07,184.07,0,0,1-88-22.38V72Zm0,128H40V131.64A200.19,200.19,0,0,0,128,152a200.25,200.25,0,0,0,88-20.37V200ZM104,112a8,8,0,0,1,8-8h32a8,8,0,0,1,0,16H112A8,8,0,0,1,104,112Z"></path></svg>
{{end}}
</span>
<h3 class="flex items-center mb-1 text-lg font-semibold text-gray-900 dark:text-white">{{.position}}
<!-- <span class="bg-blue-100 text-blue-800 text-sm font-medium me-2 px-2.5 py-0.5 rounded dark:bg-blue-900 dark:text-blue-300 ms-3">Latest</span>-->
Expand Down Expand Up @@ -71,8 +75,11 @@ <h3 class="mb-6 text-3xl font-bold text-gray-900 dark:text-white text-center">{{
{{ range $idx, $key := $person.education }}
<li class="mb-10 ms-6">
<span class="absolute flex items-center justify-center w-6 h-6 bg-primary-100 rounded-full -start-3 ring-8 ring-white dark:ring-gray-900 dark:bg-primary-900">
{{ if .icon }}
{{ partial "functions/get_icon" (dict "name" .icon "attributes" "class='w-5 h-5 text-primary-800 dark:text-primary-300'") }}
{{else}}
Copy link
Copy Markdown

@cursor cursor Bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Color Classes for Custom Logos

Custom company and institution logos in the resume experience block are missing the text-primary-800 dark:text-primary-300 color classes that are present on the fallback SVGs. This causes custom logos to display without the intended primary text colors, leading to visual inconsistency.

Additional Locations (1)

Fix in Cursor Fix in Web

<svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" viewBox="0 0 256 256" class="w-5 h-5 text-primary-800 dark:text-primary-300"><path d="M251.76,88.94l-120-64a8,8,0,0,0-7.52,0l-120,64a8,8,0,0,0,0,14.12L32,117.87v48.42a15.91,15.91,0,0,0,4.06,10.65C49.16,191.53,78.51,216,128,216a130,130,0,0,0,48-8.76V240a8,8,0,0,0,16,0V199.51a115.63,115.63,0,0,0,27.94-22.57A15.91,15.91,0,0,0,224,166.29V117.87l27.76-14.81a8,8,0,0,0,0-14.12ZM128,200c-43.27,0-68.72-21.14-80-33.71V126.4l76.24,40.66a8,8,0,0,0,7.52,0L176,143.47v46.34C163.4,195.69,147.52,200,128,200Zm80-33.75a97.83,97.83,0,0,1-16,14.25V134.93l16-8.53ZM188,118.94l-.22-.13-56-29.87a8,8,0,0,0-7.52,14.12L171,128l-43,22.93L25,96,128,41.07,231,96Z"></path></svg>
</svg>
{{end}}
Copy link
Copy Markdown

@cursor cursor Bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Template Inconsistency Causes Logo Rendering Issues

The resume-experience and resume-biography-3 templates expect different field names for custom education entry logos (institution_logo vs. icon). This inconsistency means custom logos will only render in one template at a time, with the other falling back to a default icon.

Additional Locations (1)

Fix in Cursor Fix in Web

</span>
<h3 class="flex items-center mb-1 text-lg font-semibold text-gray-900 dark:text-white">{{.area}}
<!-- <span class="bg-blue-100 text-blue-800 text-sm font-medium me-2 px-2.5 py-0.5 rounded dark:bg-blue-900 dark:text-blue-300 ms-3">Latest</span>-->
Expand Down
7 changes: 5 additions & 2 deletions starters/academic-cv/content/authors/admin/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ interests:
education:
- area: PhD Computer Science (AI Focus)
institution: Stanford University
icon: ""
date_start: 2015-09-01
date_end: 2019-06-30
summary: |
Expand All @@ -65,6 +66,7 @@ education:
url: 'https://example.com/thesis.pdf'
- area: MS Computer Science
institution: Carnegie Mellon University
icon: ""
date_start: 2013-09-01
date_end: 2015-05-31
summary: |
Expand All @@ -73,6 +75,7 @@ education:
Specialized in machine learning and robotics.
- area: BS Computer Science
institution: MIT
icon: ""
date_start: 2009-09-01
date_end: 2013-05-31
summary: |
Expand All @@ -84,15 +87,15 @@ work:
- position: Senior AI Research Scientist
company_name: Meta AI
company_url: 'https://ai.meta.com/'
company_logo: ''
icon: ''
date_start: 2020-01-01
date_end: ''
summary: |2-
Leading research on multimodal AI systems. Contributed to Llama 2 and other open-source models. 50+ citations in 3 years.
- position: AI Research Intern
company_name: OpenAI
company_url: 'https://openai.com/'
company_logo: ''
icon: ''
date_start: 2019-06-01
date_end: 2019-12-31
summary: |
Expand Down