Conversation
It contains the error code which can be negative (actually, it is never set to positive value).
It makes sense to set it to a known value so that we do not use the old value in case it wasn't set (like when there was a timeout).
bl808_i2c_start_transfer() never set's the i2c_dev->msg_err itself, it is only set by an interrupt but this will be valid only if we get a completion. In this place, we should just return ret.
By using resource managed request_irq we don't have to worry about freeign it manualy.
Show the TX/RX fifo counter when writing FIFO error log message so that we can better understand when exactly is this interrupt generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few additional fixed here and there.