Skip to content

Conversation

@lampajr
Copy link
Member

@lampajr lampajr commented Mar 28, 2025

Fixes Issue

The method Run.addRun was properly configured to return an array of ints but the implementation was returning it as String.

This is causing some issues on the auto generate Python client as it is expecting an array but getting a single element instead - The same problem does not happen in Golang as for some reason it is able to parse it anyway.

This method is not used anywhere in the source code, nor in the Jenkins plugin.

Changes proposed

  • Simply return the List (with one single element though to avoid breaking the API)
  • Do not add any header as not actually required (especially because not used)

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@stalep stalep merged commit 9f00dbe into Hyperfoil:master Mar 31, 2025
3 checks passed
@lampajr lampajr deleted the fix_add_run_api_master branch March 31, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants