Skip to content

[backend] Fix enum logic #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msanlli merged 5 commits into from
Jan 1, 2025
Merged

[backend] Fix enum logic #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbc7cca
fix enum logic
msanlli Dec 28, 2024
0e1a797
empty enum exception
msanlli Dec 31, 2024
bd9389a
adapt to enumValues ADJ logic
msanlli Jan 1, 2025
c7161a5
deprecate old range finding logic
msanlli Jan 1, 2025
72d3898
update adj
msanlli Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/cmd/JSON_ADE
Open in desktop
Submodule JSON_ADE updated from c5f6b5 to 7a3da6
8 changes: 1 addition & 7 deletions backend/internal/pod_data/measurement.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,11 @@ func getNumericMeasurement(adeMeas adj.Measurement, globalUnits map[string]utils
warningRange := adeMeas.WarningRange

displayUnits, err := utils.ParseUnits(adeMeas.DisplayUnits, globalUnits)

if err != nil {
measErrs.Add(err)
}

podUnits, err := utils.ParseUnits(adeMeas.PodUnits, globalUnits)

if err != nil {
measErrs.Add(err)
}
Expand All @@ -87,14 +85,10 @@ func getEnumMeasurement(adeMeas adj.Measurement) EnumMeasurement {
Id: adeMeas.Id,
Name: adeMeas.Name,
Type: EnumType,
Options: getEnumMembers(adeMeas.EnumValues),
Options: adeMeas.EnumValues,
}
}

func getEnumMembers(enumExp []string) []string {
return enumExp
}

func getBooleanMeasurement(adeMeas adj.Measurement) BooleanMeasurement {
return BooleanMeasurement{
Id: adeMeas.Id,
Expand Down
2 changes: 0 additions & 2 deletions backend/internal/pod_data/pod_data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ func getBoard(adjBoard adj.Board, globalUnits map[string]utils.Operations) (Boar

packets := make([]Packet, 0)

// TESTING

for _, adjPacket := range adjBoard.Packets {
packet, err := getPacket(adjPacket) // Black magic fuck
if err != nil {
Expand Down
47 changes: 0 additions & 47 deletions backend/internal/utils/range.go
View file
Open in desktop

This file was deleted.

Loading