Skip to content

[Backend] Fix backoff #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msanlli merged 2 commits into from
Jun 12, 2025
Merged

[Backend] Fix backoff #315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b773b0f
Fix backoff
JFisica Jun 12, 2025
c76e29a
Merge branch 'develop' into backend/fix-backoff
msanlli Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions backend/pkg/transport/network/tcp/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,25 @@ func (client *Client) Dial() (net.Conn, error) {
var err error
var conn net.Conn
client.logger.Info().Msg("dialing")
// Reset retry counter when starting a new dial attempt
client.currentRetries = 0


for client.config.MaxConnectionRetries <= 0 || client.currentRetries < client.config.MaxConnectionRetries {
// Increment retry counter and calculate backoff
client.currentRetries++

backoffDuration := client.config.ConnectionBackoffFunction(client.currentRetries)
client.logger.Error().Stack().Err(err).Dur("backoff", backoffDuration).Int("retry", client.currentRetries).Msg("retrying after backoff")

// Sleep for backoff duration
time.Sleep(backoffDuration)

conn, err = client.config.DialContext(client.config.Context, "tcp", client.address)

if err == nil {
client.logger.Info().Msg("connected")
client.currentRetries = 0
return conn, nil
}

// Check if context was cancelled
if client.config.Context.Err() != nil {
client.logger.Error().Stack().Err(client.config.Context.Err()).Msg("canceled")
Expand All @@ -62,14 +69,6 @@ func (client *Client) Dial() (net.Conn, error) {
client.logger.Error().Stack().Err(err).Msg("failed with non-retryable error")
return nil, err
}

// Increment retry counter and calculate backoff
client.currentRetries++
backoffDuration := client.config.ConnectionBackoffFunction(client.currentRetries)
client.logger.Error().Stack().Err(err).Dur("backoff", backoffDuration).Int("retry", client.currentRetries).Msg("retrying after backoff")

// Sleep for backoff duration
time.Sleep(backoffDuration)
}

client.logger.Debug().Int("max", client.config.MaxConnectionRetries).Msg("max connection retries exceeded")
Expand Down
Loading