Skip to content

[Common front] Fix protection packets for non-number values #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msanlli merged 2 commits into from
Jun 12, 2025
Merged

[Common front] Fix protection packets for non-number values #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c0ef6a
Fix for undefined protection packet values
JFisica Jun 11, 2025
5292e06
Merge branch 'develop' into common-front/fix-protection-packets
msanlli Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions ...gesContainer/Messages/MessageView/ProtectionMessageView/ProtectionView/ProtectionView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ type Props = {

const DECIMALS = 2;

function safeFixed(val: any, decimals = DECIMALS) {
return typeof val === "number" ? val.toFixed(decimals) : String(val);
}

export const ProtectionView = ({ protection }: Props) => {
const ProtectionText = getProtectionText(protection);

Expand All @@ -20,53 +24,52 @@ function getProtectionText(protection: ProtectionMessage) {
<>
<span>
{" "}
Want: [{protection.payload.data.bounds[0].toFixed(
DECIMALS
)}, {protection.payload.data.bounds[1].toFixed(DECIMALS)}]
Want: [
{safeFixed(protection.payload.data.bounds?.[0])}, {safeFixed(protection.payload.data.bounds?.[1])}]
</span>{" "}
<span>Got: {protection.payload.data.value.toFixed(DECIMALS)}</span>
<span>Got: {safeFixed(protection.payload.data.value)}</span>
</>
);
case "UPPER_BOUND":
return (
<>
<span>
Want: [{protection.name}] {"<"} {protection.payload.data.bound.toFixed(DECIMALS)}
Want: [{protection.name}] {"<"} {safeFixed(protection.payload.data.bound)}
</span>{" "}
<span>Got: {protection.payload.data.value.toFixed(DECIMALS)}</span>
<span>Got: {safeFixed(protection.payload.data.value)}</span>
</>
);
case "LOWER_BOUND":
return (
<>
<span>
Want: [{protection.name}] {">"} {protection.payload.data.bound.toFixed(DECIMALS)}
Want: [{protection.name}] {">"} {safeFixed(protection.payload.data.bound)}
</span>{" "}
<span>Got: {protection.payload.data.value.toFixed(DECIMALS)}</span>
<span>Got: {safeFixed(protection.payload.data.value)}</span>
</>
);
case "EQUALS":
return (
<>
<span>
Mustn't be {protection.payload.data.value.toFixed(DECIMALS)}
Mustn't be {safeFixed(protection.payload.data.value)}
</span>
</>
);
case "NOT_EQUALS":
return (
<>
<span>
Must be {protection.payload.data.want.toFixed(DECIMALS)} but is{" "}
{protection.payload.data.value.toFixed(DECIMALS)}
Must be {safeFixed(protection.payload.data.want)} but is{" "}
{safeFixed(protection.payload.data.value)}
</span>
</>
);
case "TIME_ACCUMULATION":
return (
<span>
Value was {protection.payload.data.value.toFixed(DECIMALS)} for{" "}
{protection.payload.data.timelimit.toFixed(DECIMALS)} seconds
Value was {safeFixed(protection.payload.data.value)} for{" "}
{safeFixed(protection.payload.data.timelimit)} seconds
</span>
);
case "ERROR_HANDLER":
Expand Down
Loading